FintasticMan
FintasticMan
> If we just need to do `npm install`, then we could simplify the workflow a bit. Could you update those files in `.github` as well? I've just done this,...
Oh yeah, forgot to do that.
I wouldn't worry much about the compiler version; InfiniTime works with most versions. What I do worry about is the nRF SDK version. I can't see that this specifies a...
InfiniTime requires 15.3.0.
> I would put the .devcontainer/README.md into docs/usingDevcontainers.md, maybe? Seems good to me. One more thing, make sure to add a trailing line feed to files, so that the diff...
Which linter are you using? clang-format should add trailing newlines, or at the very least not remove them. We mostly stick to having trailing newlines, and I think that almost...
I don't think there should be any difference in build size... The build size it's being compared to is 512ebf07043510930256e3c12498046b510ef8a1, rather than 8e2dcda14fac3e9ebc3b592439ad1f2afbbc7076. For some reason it is comparing against...
@BloodStainedCrow I've just fixed that merge commit, so now I believe this pull request is in a good enough state to be squash merged.
That's right, but you shouldn't pull those 22 commits, you should force push the current state of your local branch to GitHub.
I would say using the internal FIFO and polling in the SystemTask loop would be the best option, but I'd be open to other options. #1145 implements using the FIFO...