x-dash icon indicating copy to clipboard operation
x-dash copied to clipboard

new component creation/blueprint papercuts

Open apaleslimghost opened this issue 7 years ago • 2 comments

  • stories files are created but not hooked up to storybook
    • adding stories to storybook isn't documented any more
  • running storybook isn't enough to get hot reloading working; need to run npm start in the component

apaleslimghost avatar Oct 10 '18 13:10 apaleslimghost

stories files are created but not hooked up to storybook

I guess we could do some sort of Webpack magic here? The components.js file is no longer used as a source for docs IIRC so it's solely for Storybook now.

adding stories to storybook isn't documented any more

Oh bum, my bad.

running storybook isn't enough to get hot reloading working

As mentioned in #177 if Storybook could be run at the repository root we could point it directly at the source files.

i-like-robots avatar Oct 10 '18 13:10 i-like-robots

for 1 i was thinking the blueprint script could just munge register-components.js and package.json when it runs? pointing storybook at source files would be good

apaleslimghost avatar Oct 10 '18 13:10 apaleslimghost