Federico Di Pierro comments

Results 863 comments of


                                            Federico Di Pierro

trafficstars

[Tracking] Params inconsistencies in our drivers

First 2 points will be addressed by #526

pdig/libs compilation is failing

HI @tmukharj ! Thanks for this research; mind to open a PR to fix this? :rocket:

pdig/libs compilation is failing

/remove-lifecycle stale

pdig/libs compilation is failing

/remove-lifecycle stale

refactor(libsinsp): manage memory in ast/parser via unique_ptrs

/cc @jasondellaluce

bpf: fix build on some kernels

Wow thank you very much! I love tiny yet important fixes :) /cc @Andreagit97 /ok-to-test

[WIP] cleanup(driver,userspace/libscap,userspace/libsinsp): dropped simpleconsumer mode and simple driver concepts

/cc @gnosek

[WIP] cleanup(driver,userspace/libscap,userspace/libsinsp): dropped simpleconsumer mode and simple driver concepts

@Andreagit97 i refactored all the kmod main to always pass through the `force_tp_set` function when registering/unregistering tracepoints. The code is much more compact and clean now :)

[WIP] cleanup(driver,userspace/libscap,userspace/libsinsp): dropped simpleconsumer mode and simple driver concepts

We still miss: - [ ] dropping UF_ALWAYS_DROP logic -> TODO: potentially leave it to a subsequent PR; see https://github.com/falcosecurity/libs/pull/521#issuecomment-1205032197 - [x] ~~possibly dropping `PPM_IOCTL_ENABLE/DISABLE_SIGNAL_DELIVER`, and possibly even `PPM_IOCTL_ENABLE_PAGE_FAULTS` @gnosek...

[WIP] cleanup(driver,userspace/libscap,userspace/libsinsp): dropped simpleconsumer mode and simple driver concepts

@incertum this PR gives scap-open the ability to entirely disable tracepoints and mark syscalls as uninteresting while starting, like doing: ``` sudo ./libscap/examples/01-open/scap-open --bpf driver/bpf/probe.o --tp sys_exit --ppm_sc 27 --ppm_sc...