jackson-modules-java8 icon indicating copy to clipboard operation
jackson-modules-java8 copied to clipboard

ZonedDateTime documentation seems to be incorrect

Open AceHack opened this issue 5 years ago • 3 comments

It says: https://github.com/FasterXML/jackson-modules-java8/tree/master/datetime

For string representation default formats for deserialization are:

Java type Format
ZonedDateTime DateTimeFormatter.ISO_ZONED_DATE_TIME

But in the code I see: https://github.com/FasterXML/jackson-modules-java8/blob/1534c557d4ea997b7a80a9bcba4c98cd558e4493/datetime/src/main/java/com/fasterxml/jackson/datatype/jsr310/ser/ZonedDateTimeSerializer.java#L22-L23

AceHack avatar Apr 09 '20 03:04 AceHack

Yes, and the comment could be improved too. A little ambiguous though perhaps trying to explain why ISO_OFFSET_DATE_TIME is used and not ISO_ZONED_DATE_TIME.

kupci avatar Apr 09 '20 18:04 kupci

@cowtowncoder please confirm As per the issue description documentation seems to be incorrect. Is that correct? or implementation needs to be updated to match the documentation?

mydata avatar Oct 13 '22 15:10 mydata

@mydata Generally documentation should match implementation unless indicated otherwise. So I'd start with that.

cowtowncoder avatar Oct 14 '22 21:10 cowtowncoder