jackson-module-scala icon indicating copy to clipboard operation
jackson-module-scala copied to clipboard

Refactor - adding different scala object detecting

Open marcinbelicki opened this issue 2 years ago • 5 comments

I'm adding ScalaObject along with ScalaObjectTest to detect whether given Class[_] is a scala singleton object. I'm not sure if clazz can be a null but I'm adding Option(clazz) in ScalaObjectDeserializerResolver just in case.

marcinbelicki avatar Nov 30 '23 17:11 marcinbelicki

build fails with

[info] com.fasterxml.jackson.module.scala.ScalaObjectMapperTest *** ABORTED ***
[info]   java.lang.InternalError: Malformed class name
[info]   at java.lang.Class.getSimpleName(Class.java:1330)
[info]   at com.fasterxml.jackson.module.scala.util.ScalaObject$.unapply(ScalaObject.scala:27)

pjfanning avatar Nov 30 '23 18:11 pjfanning

I've corrected clazz.getSimpleName to clazz.getName - I wasn't aware that classes from inside of scala singleton objects cant produce propper simple name :/

marcinbelicki avatar Nov 30 '23 19:11 marcinbelicki

@marcinbelicki I've started #657 - I may grab more of the changes in this PR but there I don't like all the new classes in this PR

pjfanning avatar Nov 30 '23 20:11 pjfanning

Ok, I see your point

marcinbelicki avatar Dec 01 '23 12:12 marcinbelicki

@marcinbelicki #657 is merged and will appear in v2.16.1 release - thanks for driving this

pjfanning avatar Dec 01 '23 13:12 pjfanning