jackson-module-kotlin icon indicating copy to clipboard operation
jackson-module-kotlin copied to clipboard

Missing classes error using AGP 8 R8 shrinker

Open aroyarexs opened this issue 1 year ago • 1 comments

Search before asking

  • [X] I searched in the issues and found nothing similar.
  • [X] I searched in the issues of databind and other modules used and found nothing similar.
  • [ ] I have confirmed that the problem only occurs when using Kotlin.

Describe the bug

We are currently migrating from AGP 7 to 8. AGP 8 sets android.r8.failOnMissingClasses to true by default. Therefore we are now getting missing class errors.

Missing class java.beans.ConstructorProperties (referenced from: void com.fasterxml.jackson.databind.ext.Java7SupportImpl.<init>() and 2 other contexts)
Missing class java.beans.Transient (referenced from: void com.fasterxml.jackson.databind.ext.Java7SupportImpl.<init>() and 1 other context)

Using AGP 7 we receive this output as a warning. Therefore I assume we can add them savely to our proguard-rules.pro file!?

Regards,

Aaron

To Reproduce

Expected behavior

No missing class errors or some hints in the documentation.

Versions

Kotlin: 1.8.21 Jackson-module-kotlin: 2.14.3 and 2.16.2 Jackson-databind: resolved transitively -> 2.14.3 and 2.16.2

Additional context

No response

aroyarexs avatar May 02 '24 11:05 aroyarexs

This does not appear to be a problem with this repository. After reading the following article, if there is any missing information, could you please put the issue in that repository? https://github.com/FasterXML/jackson-docs/wiki/JacksonOnAndroid

k163377 avatar May 04 '24 03:05 k163377