DO-NOT-MERGE: debug #1514

[ChristianTackeGSI]

trafficstars

See: #1514

---

Checklist:

• [ ] Followed the Contributing Guidelines

Summary by CodeRabbit

• New Features

  • Introduced ls method to list objects in FairGeoInterface and FairGeoLoader.

• Bug Fixes

  • Adjusted log display lines from 50 to 100 for failed devices in test-splitMQ.sh.in.

• Chores

  • Updated build configurations: removed macOS, added Fedora, and removed specific Debian/Ubuntu versions.

• Improvements

  • Enhanced destructor handling in FairGeoSet for non-owning TList objects.

[coderabbitai[bot]]

Walkthrough

Walkthrough

The changes encompass a variety of modifications across several files. Key adjustments include enhancing log output in a test script, refining the destructor in a transport device class, improving header inclusions and type assertions, initializing class members, adding new methods for listing objects, and updating build configurations. Additionally, a new method was introduced to manage a non-owning TList in the FairGeoSet destructor.

Changes

Files/Paths	Change Summary
examples/MQ/pixelSimSplit/run/scripts/...	Increased log lines displayed from 50 to 100 for failed devices in test-splitMQ.sh.in.
fairroot/base/sim/FairModule.h	Reordered includes, added new includes, and introduced static assertions in ConstructASCIIGeometry.
fairroot/geobase/FairGeoInterface.cxx	Added include, initialized members, added ls method, and modified print method.
fairroot/geobase/FairGeoInterface.h	Introduced new ls method in FairGeoInterface class.
fairroot/geobase/FairGeoLoader.cxx	Added new ls method calling various ls methods and adjusting directory level.
fairroot/geobase/FairGeoLoader.h	Added new ls method with override in FairGeoLoader class.
Jenkinsfile	Removed specific build configurations for Debian/Ubuntu, added Fedora, and removed macOS configurations.
fairroot/geobase/FairGeoSet.cxx	Added conditional check and operation in destructor to handle non-owning TList object.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant TestScript
    participant LogFile
    participant FairMQTransportDevice
    participant FairModule
    participant FairGeoInterface
    participant FairGeoLoader
    participant FairGeoSet

    User->>TestScript: Run test-splitMQ.sh.in
    TestScript->>LogFile: Display 100 lines for failed devices
    FairMQTransportDevice->>FairMQTransportDevice: Destructor with logging and conditional method call

    FairModule->>FairModule: Include adjustments and static assertions
    FairGeoInterface->>FairGeoInterface: Initialize members, add ls method
    FairGeoLoader->>FairGeoLoader: Add ls method
    FairGeoSet->>FairGeoSet: Destructor handles non-owning TList

This diagram illustrates the primary interactions and changes introduced in this update, focusing on the new methods and adjustments in logging, destructors, and includes.

---

Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits

Files that changed from the base of the PR and between b802e4a2e6e84c7d5c2e58f59462ec04746bce1c and 332e015889d414482ff35bb254a6881c05f1d6bc.

Files selected for processing (1)

• fairroot/geobase/FairGeoSet.cxx (1 hunks)

Additional comments not posted (1)

fairroot/geobase/FairGeoSet.cxx (1)

44-49: The changes in the destructor handle the non-ownership of volumes correctly.

This ensures that there is no double deletion of objects, which is crucial for memory management in C++. Good job on this preventive measure!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.