fabulously-optimized icon indicating copy to clipboard operation
fabulously-optimized copied to clipboard

BadOptimizations

Open imthosea opened this issue 1 year ago • 10 comments

CurseForge link

https://curseforge.com/minecraft/mc-mods/badoptimizations

CurseForge Mod Distribution

Allowed

Modrinth link

https://modrinth.com/mod/badoptimizations/

Source/other link

https://github.com/ItsThosea/BadOpitmizations

Mod file size

~370 KB

License

(any other license)

What it does

  • Cancels lightmap updates if unnecessary
  • Caches current sky color to avoid recalculating it
  • Prevents calling some methods when not needed e.g. debug renderers without debug nodes

Why should it be in the modpack

  • Very simple. Config to disable possibly problematic optimizations.
  • Improves performance. On my own testing with Fabulously Optimized 1.20.4 (I have an RTX 3060 and a 12th gen i7-12700):
    • 1926-1955 FPS without BadOptimizations and without any toasts:
    • 1351-1384 FPS without BadOptimizations and with advancement toasts:
    • 2008-2023 FPS with BadOptimizations and without any toasts:
    • 1414-1458 with BadOptimizations and with advancement toasts:

Why shouldn't it be in the modpack

  • Performance impact is usually small but mostly varies on PC.
  • Might have some hidden compatibility issues.

Additional details

No response 1/3/2024 edit: adjust for 1.5.0 5/10/2024 edit: I can't stand to read the old thing I typed out even tho this got rejected

imthosea avatar Dec 26 '23 20:12 imthosea

When flying around Decked Out 2 in Hermitcraft's Season 9 world, I lose 20-30 FPS on average and have an unstable frame rate with this mod. Is this due to this mod not liking Intel UHD Graphics or some mods in FO? For reference, I am on Fadora Linux using a Intel Core i5-10210U CPU at 1080p.

cochcoder avatar Jan 09 '24 22:01 cochcoder

I've done some testing and I can conform that this decrease of performance is due to not liking Linux, I have made a issue on this mod's github page to track any improvments: #20

cochcoder avatar Jan 14 '24 22:01 cochcoder

@Madis0 my issue has been fixed and this mod would make a great addition to this modpack!

cochcoder avatar Apr 19 '24 22:04 cochcoder

Maybe. Could reevaluate the mod after 1.20.5 is released and in a reasonably stable state.

Madis0 avatar Apr 20 '24 10:04 Madis0

Oh.right...1.20.5...🫠

imthosea avatar Apr 20 '24 12:04 imthosea

Maybe. Could reevaluate the mod after 1.20.5 is released and in a reasonably stable state.

1.20.6 is out now :3

nyabinary avatar May 11 '24 01:05 nyabinary

Maybe. Could reevaluate the mod after 1.20.5 is released and in a reasonably stable state.

1.20.6 is out now :3

Well, FO for 1.20.6 is not in a stable or even beta state yet. Still, you are free to test the mod to see if it still has any benefit in FO.

Madis0 avatar May 11 '24 07:05 Madis0

BadOptimizations breaks Polytone (with a Polytone-compatible resource pack equipped) at the moment, I've also had issues with it turning the sky completely grey. For how micro-optimizations-ey these changes seem it feels like it's not worth to add it to the modpack for the instabilities and incompatibilities it causes.

Niterux avatar Jun 01 '24 07:06 Niterux

Seems to improve FPS a lil bit for me :p

nyabinary avatar Aug 04 '24 02:08 nyabinary