yarn icon indicating copy to clipboard operation
yarn copied to clipboard

The UnlockRecipesS2CPacket class also removes unlocked recipes

Open haykam821 opened this issue 2 years ago • 3 comments

The UnlockRecipesS2CPacket class suggests that it is sent when new recipes are unlocked. While this is true when initializing and adding unlocked recipes, the packet also handles removing unlocked recipes (UnlockRecipesS2CPacket.Action.REMOVE). I suggest the name UnlockedRecipesS2CPacket for this class and its associated methods to clarify that it handles generic updating of unlocked recipes, much like how the ChatSuggestionsS2CPacket class supports adding, removing, and setting chat suggestions.

haykam821 avatar Sep 16 '23 16:09 haykam821

UpdateRecipesS2CPacket?

Dev0Louis avatar Sep 16 '23 16:09 Dev0Louis

Oh no this implies that new recipes are added, your Name is better.

Dev0Louis avatar Sep 16 '23 16:09 Dev0Louis

Or maybe ChangeUnlockedRecipesS2CPacket, though this one is borderline excessive.

bluebear94 avatar Oct 03 '23 07:10 bluebear94