JuStach

Results 28 comments of JuStach

I just tried with the last master version (4.14.0-beta.2), builded locally, imported to the live project, still have the serdes errors about dates. Then i added your fix (202-204 in...

Hi @robertjustjones, can you tell me wich test you expect to fail ? EDIT: get it, should be the "should control GOOD id format and get a response in expected...

I did some test using a reduced an anonymized part of our project schema, get it to work correctly. here is a gist: https://github.com/robertjustjones/express-openapi-validator/commit/9631dfd99edfeaae1c58cb402c80d3d6c367ce7b#diff-79c6ff5eb8a158b26e0c693cf08386a520d8bd27866f170ca808134d17317d5fR212 (it's an ugly WIP, please don't...

@robertjustjones, I digged about the test who should not pass without your fix, I found that it pass only when the array use a $ref. Instead, if you define the...

> Nop, i didn't push my last test at the moment

Sorry, I misunderstood your last comment, I'll check that today

@robertjustjones, no, it does not cover the case, the schema must be : ``` historyWithoutRef: type: array items: type: object properties: modificationDate: type: string format: date ``` Then, comment your...

@cdimascio we also need your review

@srgg I'm not sure if "additionalProperties" is valid before "oneOf", "additionalProperties" should be inside a schema of type object, so only in components/schemas/Variable You should try to change this part:...

@cdimascio Allow me to revive you about this MR, if we can close this quickly :) Thanks you