FTB-Chunks icon indicating copy to clipboard operation
FTB-Chunks copied to clipboard

Claim Visibility Override

Open DerSimeon opened this issue 1 year ago • 4 comments

This small PR adds an Override to force the claim visibility for teams

DerSimeon avatar Sep 22 '24 17:09 DerSimeon

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 22 '24 17:09 CLAassistant

My only concern with this approach is that the server quietly reverts any attempt to change the visibility property if the override flag has been set. Because there's no feedback to players, this could lead to player confusion and complaints to either the server admin or ourselves, which isn't ideal.

I'd prefer if the fact the visibility can't be changed was made as clear as possible to player attempting to change it...

desht avatar Oct 07 '24 10:10 desht

Also, if the change is reverted (i.e. denied), it shouldn't be necessary to resync the team's chunks, right? Since nothing's actually being changed.

desht avatar Oct 07 '24 10:10 desht

I'd prefer if the fact the visibility can't be changed was made as clear as possible to player attempting to change it...

Any suggestions on where I could implement that?

Also, if the change is reverted (i.e. denied), it shouldn't be necessary to resync the team's chunks, right? Since nothing's actually being changed.

The UI would still show that the setting has been changed even though in the background it has been reverted. That's why I send a resync.

DerSimeon avatar Oct 07 '24 20:10 DerSimeon