Make it work with ANSI and fullwidth characters

[gajus]

Does not work (breaks the string) with string that contains ANSI escape codes (e.g. colours in the terminal) or fullwidth characters.

[FGRibreau]

Hello gajus,

Thanks for your feedback, I will happily accept a PR + test for this :)

[gajus]

@FGRibreau I will happily make a PR when this package has a well defined package.json (with dependencies required for test, build, ...), test cases, code styles guide and contribution guidelines. I am not being sarcastic.

[gajus]

If you have little incentive of maintaining the existing package, I will be happy to take it over. I'd use truncate package as part of the table package (https://github.com/gajus/table/issues/1). If you are interested, please add me as an npm owner for the package (npm owner add gajus truncate and I will take it from there). I already look after a number of repositories, https://github.com/gajus.

[FGRibreau]

Hello gajus,

I will happily make a PR when this package has a well defined package.json (with dependencies required for test, build, ...), test cases, code styles guide and contribution guidelines. I am not being sarcastic.

None taken :)

• the package.json as the right dev dependencies (even if they should be more strict)
• node-truncate has tests
• code styles guide & contribution guidelines are not present but they are also not present in gajus/table, so your feedback is kind of funny :)

If you have little incentive of maintaining the existing package, I will be happy to take it over. I'd use truncate package as part of the table package (gajus/table#1). If you are interested, please add me as an npm owner for the package (npm owner add gajus truncate and I will take it from there). I already look after a number of repositories, https://github.com/gajus.

Thanks for you offer! But I would prefer to keep the lead on this project :)

[stevenvachon]

+1