dolfinx icon indicating copy to clipboard operation
dolfinx copied to clipboard

Support GMSH/VTK prism/pyramid cells

Open tiagovla opened this issue 3 years ago • 2 comments

I noticed the cpp io interface does not yet support GMSH/VTK prism/pyramid cells which might be needed to support hybrid 3d meshes in the future. Could I make PR to contribute on that?

  • [ ] Add logic to cells.cpp
  • [ ] Add documentation to cells.h
  • [ ] Add tests (maybe test fixtures)

tiagovla avatar Apr 16 '22 22:04 tiagovla

@tiagovla Feel free to add such a contribution to the code. As far as I can tell by quickly looking at: https://raw.githubusercontent.com/Kitware/vtk-examples/gh-pages/src/Testing/Baseline/Cxx/GeometricObjects/TestLinearCellDemo.png and https://github.com/FEniCS/basix#prism The map for a first order prism/wedge is the identity: [0,1,2,3,4,5] while the map for a pyramid is : [0,1,2,3,2,4]. Feel free to try to add these for vtk and check the correctness by writing it to pvd (VTKFile).

jorgensd avatar Apr 19 '22 10:04 jorgensd

I'd suggest waiting on this until we have the low-level plumbing in place for mixed topologies.

garth-wells avatar Apr 23 '22 09:04 garth-wells