terraform-provider-bigip icon indicating copy to clipboard operation
terraform-provider-bigip copied to clipboard

Fix handling of single quotes in shell commands

Open alex-harvey-z3q opened this issue 1 year ago • 2 comments

Previously, if a command in the bigip_command resource contained single quotes, the constructed shell command would have unbalanced quotes, leading to syntax errors and command execution failures. This commit fixes the issue by escaping single quotes within the commands before wrapping them in single quotes. This ensures that all commands are properly formatted and executed, even if they contain single quotes.

  • Escape single quotes in commands before constructing the shell command
  • Prevents syntax errors due to unbalanced quotes
  • Enhances security by mitigating potential command injection risks

alex-harvey-z3q avatar Oct 06 '24 07:10 alex-harvey-z3q

Hi @alex-harvey-z3q, Thanks for your PR.

In order to review and accept your commit, you need to sign a Customer License Agreement and send it to [email protected]

https://clouddocs.f5.com/products/orchestration/ansible/devel/_downloads/b35c2904c64e94ec52f5e300bfbebfc4/F5-Contributor-License-Agreement.pdf

RavinderReddyF5 avatar Oct 15 '24 14:10 RavinderReddyF5

Hi @alex-harvey-z3q, you PR changes are taken through PR: #1025

RavinderReddyF5 avatar Oct 21 '24 13:10 RavinderReddyF5

Hi @alex-harvey-z3q , as per previous comments we are closing this ticket

RavinderReddyF5 avatar Dec 03 '24 06:12 RavinderReddyF5