detect_number not working as expected?

[skasai5296]

Thanks for the great repo!

I was looking at how you parsed the captions, but in adversarial_attack/numeral.py the program hangs with a sentence ending in a number, with no period.

detect_number("she is 13")

I made a workaround by converting line 24, continue to break. Could this cause unintended behavior?

[skasai5296]

I guessed that this function takes the numbers that have nouns after them, but I think this wouldn't cause much problem in that case. A non-working case would be "the number of zebras in this picture is three" but it is an unlikely case though...

[ExplorerFreda]

Hi -- Thanks for pointing out this! You've successfully found a bug. I'd try to work it out.