App
App copied to clipboard
Expensify
Chat -Green line displays after send attachment/messages offline and come back online.
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Launch the app
- Log in with any account
- Turn off your internet connection
- Create a new room
- Tap on plus button
- Select Add Attachment
- Send Attachment
- Enable the internet connection
Expected Result:
There is no green line displayed after come back online
Actual Result:
New line displays after send attachment offline and come back online.
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.5.0
Reproducible in staging?: Yes
Reproducible in production?: No, can not create room while offline
Email or phone of affected tester (no customers): any expensifail account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/191973668-4c1fd8aa-ec33-4dac-beae-84b95db77c75.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
is this only on Android, or does this happen in other platforms? It seems weird to be platform specific
Also please correct the title, it's a bit confusing as New line means a empty line in programing language, aka return/enter, did you mean Green Line?
thanks :)
@marcaaron I think this change might have been the cause of it? As it's a relative new change, and I think we just added the QA testrail steps yesterday.
This said, I'm not 100% this should be a deploy blocker. Offline first stuff are a new feature, so it makes sense it's not in prod yet. Also this seems to be an edge case.
@kbecciv is this for attachements only, or would it be an issues with messages as wel:?
The same issue with message
https://user-images.githubusercontent.com/93399543/191980433-67e86fb6-3ed9-457d-af6e-048801b0f470.mp4
Ok, after some investigation I was able to reproduce the bug in Prod.
Here are the reproduction steps:
- Launch the app
- Log in with any account
- Create a new room
- Turn off your internet connection
- write a new comment
- Enable the internet connection
after a while the green line will appear.
I Don't think this is related to the Add Room Offline functionality. I'm inclined to remove the blocker, as I was able to reproduce something that I think it's the actual issue.
I couldn't reproduce this. This seems really similar to https://github.com/Expensify/App/issues/11216. Per this comment I'll tag @marcaaron so you can keep it in your radar.
I'll remove the blocker on this one since it seems like an inconsistent minor UI issue.
⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
idk I think it can still be a Daily and added to the Whats App Quality milestone. No reason why someone can't look into this.
I'm gonna take this off the Unread Indicators milestone and move it to Whats App quality. Looks like tester is using an optimistic report and I have no idea whether unread indicators were taken into consideration for the optimistic report stuff.
I can't replicate this on dev, none of the steps previously described, will try again on staging
I'm having some trouble checking on this today, I think it's because I'm working from a coworking space today, will chack again on monday from home
I can no longer replicate this, neither in staging or dev. I do get duplicated Messages, but I think that is a different issue and the changes on the sequenceNumber
demoting this to weekly, as I don't think this is happening anymore.
@kbecciv can your team take a look to see if it still happens?
@sketchydroide Issue is reproduced with latest build 1.2.16-4
https://user-images.githubusercontent.com/93399543/196197000-be125e5a-3bc3-416e-a42f-7faa4d4b74d4.MP4
Thanks, I think it might be part of the process the login part. let me try again.
@sketchydroide Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
still haven't had the time to check, busy with the deployment, will check again