[$500] Android - Add Phone number UI not consistent - reported by @gadhiyamanan

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to setting > profile > Add phone number
2. click on password
3. check send validation button

Expected Result:

Send validation button should not be hidden

Actual Result:

Send validation button is hidden

Platform:

• Android

Version Number: 1.1.99-0 Reproducible in staging?: Y Reproducible in production?: Y Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: https://user-images.githubusercontent.com/43995119/190951528-cf5f7ee0-d6e4-43f6-8f4f-3c38f89d6ab7.mp4

Expensify/Expensify Issue URL: Issue reported by: @gadhiyamanan Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661685271625409

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @davidcardoza (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[davidcardoza]

I can't reproduce on mobile because I am running on iOS. The workflow looks like fine on iOS though. Either way, what's shown on Android should mirror what's shown in iOS

[melvin-bot[bot]]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot[bot]]

@cead22 Eep! 4 days overdue now. Issues have feelings too...

[cead22]

This is by design. The button should be disabled because the password hasn't been entered

[cead22]

@davidcardoza if you don't understand the issue or can't reproduce it, ask for clarification before assigning to engineering, or simply close the issue

[gadhiyamanan]

@cead22 in android, when you click on a phone number user can see the button but when you click on the password keyboard will hidden

[cead22]

@gadhiyamanan can you double check if when you click password and the button appears hidden, if you can scroll down and see the button? I think it's possible the button isn't hidden, but rather, the keyboard we show for the password is taller than the one we show for the phone number, and it's covering the button, but the button isn't really disappearing.

If you can confirm the button is actually gone and you can't scroll down and see it, please reopen this issue

[gadhiyamanan]

@cead22 not able to scroll down, first I need to close the keyboard

the button disappears only for the password field and is reproducible only on android

[melvin-bot[bot]]

Triggered auto assignment to @luacmartins (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

[melvin-bot[bot]]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

@cead22 I think an external contributor can work on fixing this bug. Would you be against removing the demolition label and making this external?

[cead22]

Not at all, go for it

[melvin-bot[bot]]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot[bot]]

Current assignee @luacmartins is eligible for the External assigner, not assigning anyone new.

[Santhosh-Sellavel]

This is related to keyboard hiding content, @tgolen this should be held right?

[tgolen]

Yes! It is. I've tested this exact flow with some of my recent changes and I'm pretty certain I'll have it fixed.

[tgolen]

Putting this on HOLD for now.

[tgolen]

This is still on HOLD while I try to get https://github.com/Expensify/App/pull/11586 merged. That will then allow this to be opened up for proposals again.

[tgolen]

This is no longer on hold and can have proposals created for it with the new code.

[melvin-bot[bot]]

Triggered auto assignment to @abekkala (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[melvin-bot[bot]]

Current assignee @tgolen is eligible for the External assigner, not assigning anyone new.

[abekkala]

https://www.upwork.com/ab/applicants/1587772488630054912/job-details

https://www.upwork.com/jobs/~015814913e9779f5c9

[FilipRado]

I will fix your layout to use only 'position:absolute'. And then it will change by keyboardaware events.

[JmillsExpensify]

@abekkala Given that we're still early and no proposals have been accepted, I'm assigning myself per the new BZ process: https://stackoverflow.com/c/expensify/questions/14597/14598#14598.

[Santhosh-Sellavel]

@FilipRado Please go through our past issues and learn how to write a proper proposal.

Also checkout out our guidelines to understand our process

[JmillsExpensify]

Still waiting for proposals.

[JmillsExpensify]

Still waiting for proposals. Increasing the price to $500.