django-better-filter-widget icon indicating copy to clipboard operation
django-better-filter-widget copied to clipboard

Published 20 hours ago • verified publisher icon ExoticObjects

Add support for Django 1.11 and 2.x

Open Javierb opened this issue 7 years ago • 5 comments

Updated the render choices parameter to renderer as per the base class "Widget", otherwise "AttributeError: 'tuple' object has no attribute 'render'" is raised.

In the Django documentation is stated that support for subclasses that don’t accept the renderer parameter will be removed in Django 2.1.

Javierb avatar Apr 25 '18 09:04 Javierb

Does removal of choices break this for versions < 1.11?

unformatt avatar Apr 25 '18 14:04 unformatt

Haven't tested in older versions. Do you really want to support un-supported versions of Django?

Javierb avatar Apr 27 '18 17:04 Javierb

Since this module is 4 years old, it's in use in older systems. If an important bug is fixed in this module, people most likely don't want to go through a django upgrade process to fix a bug in a small module.

unformatt avatar Apr 27 '18 18:04 unformatt

Can we merge this? Im using django 2 and it is not working because of Attribute error regarding renderer..

josefkorbel avatar Aug 28 '18 13:08 josefkorbel

@josefkorbel If you're using pip, you can install directly from the branch: https://github.com/Javierb/django-better-filter-widget/tree/django-1-11-and-2-x-support

unformatt avatar Aug 31 '18 15:08 unformatt