Exodus-Privacy
perform some updates on exodus-core
Hi @arthru and thanks for working on this!
I don't understand why you remove the setup.py and other changes, can you explain it when it's finalize?
Hey :wave:
PEP 517 promotes pyproject.toml in place of setup.py
This PEP has been approved in september 2017, almost 8 years ago, so it is time to use it !
(moreover, I don't remember how we used to work with setup.py, so it feels easier for me...)
Thanks @arthru it's seems cool, but I also see a lot of new requirements: we try to keep only the main direct dependencies in our requirements.txt file, is there a reason to add all this new ones?
I also would like @pnu-s confirmation on this PR, but maybe he's to busy right now…
Direct dependencies are listed in pyproject.toml file (at https://github.com/Exodus-Privacy/exodus-core/pull/105/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R12 ) and requirements.txt contains all the dependency tree with version pinned
I saw in Exodus that Pipfile and Pipfile.lock are in use, I could replace the requirements.txt file by Pipfile.lock if preferred. Shall I do that ?
Direct dependencies are listed in pyproject.toml file (at https://github.com/Exodus-Privacy/exodus-core/pull/105/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R12 ) and requirements.txt contains all the dependency tree with version pinned
Oh ok, it's more clear for me, thanks.
I saw in Exodus that Pipfile and Pipfile.lock are in use, I could replace the requirements.txt file by Pipfile.lock if preferred. Shall I do that ?
If it's ok for you yes it could be cool, we use Pipfile everywhere else, an harmonization would be perfect! Thanks
I think on the matter I saw lately the Python community move to uv (https://github.com/astral-sh/uv), where it seems to gather agreement as a very good thing that came to the Python ecosystem. (I also found https://github.com/mkniewallner/migrate-to-uv if we ever think we'd like to do the move at some point).
@arthru This means here the requirements.txt is kinda used like a lockfile, is this standard practice? I believe I never saw it done that way before.
