exiv2 icon indicating copy to clipboard operation
exiv2 copied to clipboard

Initialize a non-empty PNG ICC profile name

Open kmilos opened this issue 3 years ago • 5 comments

Fixes #2354

kmilos avatar Sep 15 '22 08:09 kmilos

Fix looks good. Do we have a test image for this? (I don't see one attached to #2354 either.)

kevinbackhouse avatar Sep 15 '22 09:09 kevinbackhouse

I think conan must have made a backwards-incompatible change that's broken our build. I got the same failures in #2353.

kevinbackhouse avatar Sep 15 '22 09:09 kevinbackhouse

Fix looks good.

I might add the possibility to set the name though (API only, not CLI), as mentioned in the issue...

Do we have a test image for this?

We do have one test that seems to produce an empty profile name: https://github.com/Exiv2/exiv2/blob/d2253c91f59be50d58a387b17f37a38c2d2025f7/tests/bash_tests/testcases.py#L1013-L1094

But it should have failed now, no? Needs looking into...

kmilos avatar Sep 15 '22 10:09 kmilos

Ah, the stdin_test above is disabled 🤦

When I enable it, it does fail for many other reasons, but in the generated test/tmp/stdin-test.out I see the corrected

    9337 | iCCP  |    2604 | ICC Profile..x...wTS.....7.&.. | 0x876f2b5d

instead of the current, empty, test/data/test_reference_files/stdin-test.out reference:

    9337 | iCCP  |    2598 | ..x...wTS.....7.P.....khR.H..H | 0x915a222e

kmilos avatar Sep 15 '22 11:09 kmilos

Actually, specialization of both setICCProfile() and clearICCProfile() is mandatory now that I thought about it more...

kmilos avatar Sep 15 '22 13:09 kmilos