Initialize a non-empty PNG ICC profile name
Fixes #2354
Fix looks good. Do we have a test image for this? (I don't see one attached to #2354 either.)
I think conan must have made a backwards-incompatible change that's broken our build. I got the same failures in #2353.
Fix looks good.
I might add the possibility to set the name though (API only, not CLI), as mentioned in the issue...
Do we have a test image for this?
We do have one test that seems to produce an empty profile name: https://github.com/Exiv2/exiv2/blob/d2253c91f59be50d58a387b17f37a38c2d2025f7/tests/bash_tests/testcases.py#L1013-L1094
But it should have failed now, no? Needs looking into...
Ah, the stdin_test above is disabled 🤦
When I enable it, it does fail for many other reasons, but in the generated test/tmp/stdin-test.out I see the corrected
9337 | iCCP | 2604 | ICC Profile..x...wTS.....7.&.. | 0x876f2b5d
instead of the current, empty, test/data/test_reference_files/stdin-test.out reference:
9337 | iCCP | 2598 | ..x...wTS.....7.P.....khR.H..H | 0x915a222e
Actually, specialization of both setICCProfile() and clearICCProfile() is mandatory now that I thought about it more...