Update exiv2.pot
Use new update-pot target contributed by @cjwatson (#1907) to update exiv2.pot.
Codecov Report
Merging #1911 (00be5a4) into main (827f31a) will increase coverage by
0.00%. The diff coverage is68.75%.
:exclamation: Current head 00be5a4 differs from pull request most recent head 7c39645. Consider uploading reports for the commit 7c39645 to get more accurate results
@@ Coverage Diff @@
## main #1911 +/- ##
=======================================
Coverage 61.13% 61.13%
=======================================
Files 96 96
Lines 19059 19068 +9
Branches 9735 9745 +10
=======================================
+ Hits 11651 11657 +6
- Misses 5092 5093 +1
- Partials 2316 2318 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| include/exiv2/datasets.hpp | 100.00% <ø> (ø) |
|
| src/canonmn_int.cpp | 64.51% <ø> (ø) |
|
| src/sonymn_int.cpp | 52.88% <61.53%> (+0.12%) |
:arrow_up: |
| src/pentaxmn_int.cpp | 72.92% <100.00%> (ø) |
|
| src/tags_int.cpp | 77.05% <100.00%> (+0.24%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 78fcfff...7c39645. Read the comment docs.
I have no experience of pot files, but maybe the email address for bugs should change? I think that Andreas has no involvement in the project any longer.
po/CMakeLists.txt
[email protected]
I understand that @lbschenkel is working on localisation, but there may be a better candidate.
Also, is Andreas still the copyright holder?
po/CMakeLists.txt
--copyright-holder='Andreas Huggel'
Andreas hasn't been involved with Exiv2 since 2017. I'm not a lawyer, however my understanding is that he does not hold copyright for the open-source version of Exiv2. See: https://github.com/Exiv2/exiv2/wiki/Commercial-License
The status of @lbschenkel is unknown. Earlier this year, he volunteered to work on Exiv2 localisation using Crowdin (about which I know exactly nothing). @paolobenve offered to work on the Portuguese and asked for Crowdin assistance. There have been other occasional localisation contributions. For example, Tony contributed Catalonian, and Thomas helped with German. It would be wonderful to have a i18n tsar to own and manage localisation.
I am still here but I can only take a passive/reactive role in this project: when pinged I can help out, etc. Therefore I am not sure if I qualify, or if it is even a good idea, to be the primary contact person for bugs. I cannot promise any kind of "SLA". I think I could be more suitable as the "second-level support": if the primary maintainer has questions or needs help regarding the translation domain, then I can help them out.
Thanks @postscript-dev! Good catch on the copyright and bugs address. I have created https://github.com/cjwatson/exiv2/pull/1 to replace those with something more generic.
@lbschenkel Good to hear you're still with us. I understand your limited availability. Your help is appreciated.
Can you speak to @paolobenve please? He offered to get involved with localisation and asked me about a Crowdin Template (or something like that). Maybe you can get him up-and-running. Thanks.
@paolobenve: feel free to reach me via the e-mail address you can see in this commit: https://github.com/Exiv2/exiv2/commit/c4d18d02e718ee1573e98338756d2b35e7b31f1d.patch
We updated the copyright and contact details in #1907.
@postscript-dev: I couldn't find a way to update the copyright statement by changing the arguments to xgettext, so I just edited the file manually.
I don't know about the .po files. It looks like they all say "This file is distributed under the same license as the exiv2 package", plus the name of the person who did the translation, so that seems ok to me.
All the .po files still contain references to
"Report-Msgid-Bugs-To: [email protected]\n"
rather than
"Report-Msgid-Bugs-To: https://github.com/Exiv2/exiv2/issues\n"
(e.g., fr.po).
Will the exiv2.pot values be automatically copied into the .po files?
needs rebasing.
"Report-Msgid-Bugs-To: https://github.com/Exiv2/exiv2/issues\n"
@postscript-dev I suggest this command (tested):
posieve set-header -sfield:"Report-Msgid-Bugs-To:https://github.com/Exiv2/exiv2/issues" po/
@bellaperez
Thanks for your suggestion. As a native English speaker, I haven't needed to investigate .po files.
I don't have time to look at this at the moment but will return to the PR in the new year.
Superseded by https://github.com/Exiv2/exiv2/pull/2945?