hexo-theme-redefine icon indicating copy to clipboard operation
hexo-theme-redefine copied to clipboard

修复 404 页面无法被正确显示的问题

Open xzadudu179 opened this issue 8 months ago • 1 comments

之前想自定义 404 页面发现怎么没反应,检查了半天发现 page-helpers.js 文件中 notFound pageData 下配置 titles["404", "notfound"]types["404", "notfound"],而在 404.js 文件中注册的 404 页面 data 为

{
      title: 'Page Not Found',
      page: locals.pages.findOne({ path: '404.html' })
}

这里 title 不符合 page-helpers.jsnotFound 页面模板的规则,就加了一行 type: 'notfound',,之后就可以正确显示模板内容了

Summary by CodeRabbit

  • Refactor
    • Enhanced the error handling for pages that aren’t found. The update refines the underlying structure for processing 404 errors, ensuring more consistent categorization and clarity. While the core behavior remains unchanged for users, these improvements fortify our error page delivery, set the stage for future optimizations, and provide additional benefits.

xzadudu179 avatar Mar 02 '25 18:03 xzadudu179

📝 Walkthrough

Walkthrough

This pull request updates the 404 error page logic in scripts/events/404.js. The function signature is reformatted by adding a space after the function keyword. Additionally, a new property type with the value 'notfound' is introduced in the returned data object, while the formatting for the existing page property is adjusted for better readability.

Changes

File Path Change Summary
scripts/events/404.js Reformatted function signature (added space after function), added new property type: 'notfound' in the returned object, and adjusted key-value spacing.

Possibly related PRs

  • EvanNotFound/hexo-theme-redefine#389: Updates to the 404 error page function align with modifications in the 404 page template.
  • EvanNotFound/hexo-theme-redefine#417: Adjustments to the returned data structure of the 404 error function are related to template updates enhancing multilingual support.

Suggested labels

deployed

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 02 '25 18:03 coderabbitai[bot]

lgtm

EvanNotFound avatar Apr 15 '25 17:04 EvanNotFound