Eugene

Results 508 comments of Eugene

Excuse my possibly stupid question, but why can't zone.js override the global `Promise` constructor to monkey-patch the `then` and `catch` methods instead of waiting for the native hooks?

https://www.npmjs.com/package/patch-package

I think having an `invertedForeground` would be a more flexible solution

@Tyriar if you mean forcing the alpha component of `backgroundColor` to 1 while keeping its RGB as is, I'm in.

@Tyriar here's my attempt at this for the WebGL renderer: https://github.com/Eugeny/xterm.js/commit/cf4830442a76cb71af66b66cc257e11ad58cdd02 However, even though the color logic is fine, it leads to the reverse text looking "chipped" - see here:...

This needs to be done for both renderers - I just started with the webgl one for no specific reason.

Hey guys, is there anything I could do to help you fix this in the WebGL renderer as well?

@jerch the idea is not to make inverted FG transparent, but rather ignore the alpha part of BG: https://github.com/xtermjs/xterm.js/issues/1898#issuecomment-457948917

Could anyone who knows his way around the renderer take a second look at this? It's pretty much prevents widespread adoption of the webgl renderer.