Covid19 sample - part 1

[nanaeaubry]

trafficstars

Updated the code, ran the code, updated the screenshots

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-29T05:53:57Z ----------------------------------------------------------------

The above description and note probably need to update to reflect the data change

jyaistMap commented on 2024-08-30T15:21:38Z ----------------------------------------------------------------

I'm leaving the note as is since it still displays the data as of 2021. I think at the release after 2.4 we'll remove these samples since the Covid epidemic is in a different phase.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-29T05:53:58Z ----------------------------------------------------------------

The narrative need to update for content.add() and smart mapping

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-29T05:53:59Z ----------------------------------------------------------------

Looks like the data and map legend changed so the numbers here in the narrative also need to change :)

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-29T05:53:59Z ----------------------------------------------------------------

old numbers and polygon colors need to change for map2b

jyaistMap commented on 2024-08-30T15:22:30Z ----------------------------------------------------------------

Updated.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-29T05:54:00Z ----------------------------------------------------------------

Suggestion: as the data changed over time and the recovered cases displays as 0 now, could be good to mention in this section that the maps in this section is drawn based on previous data

jyaistMap commented on 2024-08-30T15:24:33Z ----------------------------------------------------------------

• used the previous map image so there was a display

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-29T05:54:01Z ----------------------------------------------------------------

function names need updates here

jyaistMap commented on 2024-08-30T15:24:53Z ----------------------------------------------------------------

Done.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-29T05:54:02Z ----------------------------------------------------------------

same here - need updates for numbers and colors to align with the map :)

jyaistMap commented on 2024-08-30T15:25:09Z ----------------------------------------------------------------

done

[jyaistMap]

I'm leaving the note as is since it still displays the data as of 2021. I think at the release after 2.4 we'll remove these samples since the Covid epidemic is in a different phase.

---

View entire conversation on ReviewNB

[jyaistMap]

Updated.

---

View entire conversation on ReviewNB

[jyaistMap]

• used the previous map image so there was a display

---

View entire conversation on ReviewNB

[jyaistMap]

Done.

---

View entire conversation on ReviewNB

[jyaistMap]

done

---

View entire conversation on ReviewNB