updated `part4_visualizing_time_enabled_data_on_the_map_widget.ipynb`

[ManushiM]

trafficstars

Changes:

• Changed the set_time_period method
• Replaced gifs with updated ones
• Removed ready method and replaced it with time lag
• Updated markdown description as required

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-08-23T07:04:03Z ----------------------------------------------------------------

The interval and unit are passed as a dictionary now. You list the parameters correctly but in the text is says: time_extent(start_time, end_time, interval=1, unit='milliseconds')

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-08-23T07:04:03Z ----------------------------------------------------------------

You can clear the cell output here since you have the gif below

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-08-23T07:04:04Z ----------------------------------------------------------------

Same here

[nanaeaubry]

@ManushiM Looks good just left very small comments!

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-08-23T23:40:01Z ----------------------------------------------------------------

I think the sentence should read: In order to properly call the TimeSlider.time_extent() method, we need to specify the following arguments:

Leave the parameter names out of the paragraph and just let the bulleted list explain them.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-08-23T23:40:02Z ----------------------------------------------------------------

The page looks good when I build the website locally. After the map outputs are removed and the suggested text changes are made in the paragraph above, we can merge this.

[review-notebook-app[bot]]

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-08-27T02:33:40Z ----------------------------------------------------------------

I found that in src the start_time and end_time parameters are optional. Should we also change it here in the guide?

[cariashuang0417]

Overall LGTM, thanks Manushi! Just left a comment for the parameters for the time_extent() function.

[ManushiM]

Thanks for the feedback, I addressed these changes in the next PR.