arcgis-maps-sdk-swift-toolkit icon indicating copy to clipboard operation
arcgis-maps-sdk-swift-toolkit copied to clipboard

Synchronize Bundle IDs

Open dfeinzimer opened this issue 2 years ago • 3 comments
trafficstars

We now have IDs defined across the standard examples app, the UI test runner app, the authentication examples app, and soon the JobManager example app. Additionally the toolkit has a bundle ID defined here with capitalization that differs from the others. We should align all of these across the repo to use consistent notation and capitalization.

Location Current ID Proposed ID
Toolkit Bundle Extension com.esri.ArcGISToolkit com.esri.arcgis-swift-sdk-toolkit
Examples App com.esri.arcgis-swift-sdk-toolkit-examples com.esri.arcgis-swift-sdk-toolkit.Examples
Authenticator Example App com.esri.Authentication com.esri.arcgis-swift-sdk-toolkit.AuthenticationExample
JobManager Example App com.esri.JobManagerExample com.esri.arcgis-swift-sdk-toolkit.JobManagerExample
UI Test Runner com.esri.arcgis-swift-sdk-toolkit-ui-test-runner.UITests com.esri.arcgis-swift-sdk-toolkit.UI-Test-Runner

dfeinzimer avatar Sep 05 '23 20:09 dfeinzimer

The above is correct for the JobManagerExample bundle identifier. But the logger uses:

return Logger(subsystem: "com.esri.ArcGISToolkit.Examples", category: "JobManagerExample")

That should be sync'ed up in some way when we decide what direction we want to go in.

rolson avatar Sep 05 '23 21:09 rolson

The toolkit bundle identifier follows Apple's practice of using the framework/module name as the last component of the identifier. We also wouldn't want to change the identifier of a released product as that could have unintended consequences.

philium avatar Sep 07 '23 17:09 philium

We also wouldn't want to change the identifier of a released product as that could have unintended consequences.

@philium would this hold true for a test runner too?

dfeinzimer avatar Feb 21 '24 22:02 dfeinzimer