arcgis-maps-sdk-swift-toolkit icon indicating copy to clipboard operation
arcgis-maps-sdk-swift-toolkit copied to clipboard

Published 20 hours ago • verified publisher icon Esri

Offline: consider renaming `onlyOfflineModelsAreAvailable`

Open yo1995 opened this issue 3 months ago • 0 comments
trafficstars

Description

https://github.com/Esri/arcgis-maps-sdk-swift-toolkit/blob/472d484b0190ce12aa90f76fef800e73873cb5e8/Sources/ArcGISToolkit/Components/Offline/Preplanned/PreplannedMapModel.swift#L386

This Boolean is only set here to true when a URLError is thrown, which indicates the Internet connection is bad. However, its name is a bit misleading, as it doesn't indicate whether the [PreplannedMapModel] array is empty or not.

Consider renaming it to better convey the idea that "when the device is disconnected from the Internet, you can only work with the 'offline' preplanned map areas that are already on device".

yo1995 avatar Jul 22 '25 20:07 yo1995