HotShot icon indicating copy to clipboard operation
HotShot copied to clipboard

[BUG] - Improperly handled panic behavior

Open elliedavidson opened this issue 1 year ago • 0 comments

What is this task and why do we need to work on it?

This issue was observed in jellyfish version 0.4.5

Nodes will panic if they attempt to verify a VID share with a different multiplicity than the node expects. An incorrectly configured node could cause many other network nodes to crash.

To reproduce:

  • Run 1 HotShot leader with multiplicity = 2
  • Run other HotShot nodes with multiplicity = 4
  • Replica nodes will panic in the verifiy_share function in vid/src/advz.rs

All calls to verify_share should appropriately handle a panic.

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

The above reproduction steps no longer cause the bug.

Branch work will be merged to (if not the default branch)

No response

elliedavidson avatar Jul 31 '24 21:07 elliedavidson