HotShot icon indicating copy to clipboard operation
HotShot copied to clipboard

[VID TECH DEBT] - `vid_scheme` should take `u32` instead of `usize`

Open ggutoski opened this issue 1 year ago • 0 comments

What is this task and why do we need to work on it?

Currently vid_scheme starts like this: https://github.com/EspressoSystems/HotShot/blob/e0f96004a04bcf7ae748135dc75eee528eab5356/crates/types/src/vid.rs#L78-L83

The arg num_storage_nodes should be of type u32 instead. That would eliminate the error handling cruft. It would also make life easier for downstream users, who need to convert a u32 to usize anyway: https://github.com/EspressoSystems/espresso-sequencer/blob/26a6b299ce260a210e6fa3253bbd50fb57f3023d/sequencer/src/block/full_payload/ns_proof.rs#L47-L51

What work will need to be done to complete this task?

Dead easy.

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

vid_scheme takes a u32 instead of usize

Branch work will be merged to (if not the default branch)

No response

ggutoski avatar Jun 10 '24 20:06 ggutoski