HotShot icon indicating copy to clipboard operation
HotShot copied to clipboard

[CX_HARDENING] - Audit and Improve `test_with_failures_two`

Open jparr721 opened this issue 1 year ago • 0 comments

What is this task and why do we need to work on it?

The test_with_failures_two integration test is currently always deterministically failing the exact same nodes. There exists a linked issue in the test that was originally preventing us from shutting down any node. It appears that this has been resolved, and we should take steps to remove the determinism from this test to enhance the reliability of the results.

What work will need to be done to complete this task?

  • [ ] Verify that, indeed, #1567 is closed and resolved.
  • [ ] Add a new test that removes the hard-coded node numbers and instead randomly selects from a range of valid nodes (if #1567 is not resolved, adjust this accordingly).
  • [ ] Look into adding non determinism to the Spinning Task description as well.

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

The existing test still passes, and the new test also passes.

Branch work will be merged to (if not the default branch)

No response

jparr721 avatar May 30 '24 15:05 jparr721