HotShot icon indicating copy to clipboard operation
HotShot copied to clipboard

Check Payload Commit before accepting DAVotes

Open bfish713 opened this issue 1 year ago • 0 comments

No issues

This PR:

Fernando noted during the creation of specs that we don't ever check that DA votes are for the same commitment as the block we proposed. We technically don't need this as only a bad DA committee would vote for a Fake block. We'll end up proposing to the quorum with a payload that doesn't match certificate we formed from the fake votes. We won't get quorum votes, and thus the fake block commitment will never make it on chain. This hole doesn't open us up to anything besides allowing a bad committee to timeout a view (which it can already do by just not voting at all).

This PR does not:

Key places to review:

bfish713 avatar Apr 11 '24 15:04 bfish713