Eron Wright comments

Results 245 comments of


                                            Eron Wright

Harden the Pravega dependency version against external influence

To elaborate on the issue, the `pravegaVersion` variable exists to centralize the value across numerous locations in the build script. In my opinion it should be considered to have 'private'...

Allow inner class being parameter of `withTimestampAssigner` in Table API stream table source

I'm a little concerned that we're missing an ingredient with how assigners would be configured in Flink SQL. One of the main use cases of Flink SQL is to be...

Allow inner class being parameter of `withTimestampAssigner` in Table API stream table source

Also, notice in the Kafka table source that there's a property called `sink-partitioner` (with an enum for possible values) and a property called `sink-partitioner-class`. Consider using this naming convention (`-class`)...

Improve fairness of initial allocation of segments

I'd like to make it deterministic using an optional parameter to reader group initialization for 'initial readers'.

Improve fairness of initial allocation of segments

It is normal in Flink's case that all the readers are known upfront.

Integrate flink end-to-end tests with Travis

I take the meaning to be, run `gradlew test` in the travis build. At the moment, travis is just building the code.

allow proxy-ssl-* annotations without proxy-ssl-secret

This is an important fix, because the workaround of specifying `proxy-ssl-secret` isn't easy to use with large CA bundles that don't fit into a k8s secret, such as a system...

alertmanager-config.yaml file for pagerduty_configs.details does not respect EventApi v2 spec

On the topic of PD-CEF and nested objects in `custom_details`, the specification is frankly unclear, but there's ample evidence in the PagerDuty documentation that nested objects are supported and useful....

Bundle unpacking doesn't retry after DeadlineExceeded even after resubscribing.

I encountered this issue and resolved it by deleting the `Job`s in the operator's namespace, and any `InstallPlan` too. Then I restarted the OLM operator.

Need to update api/v1beta1/zz_generated.deepcopy.go

Not ideal, but the following PR (v1 API) does have the fix: https://github.com/GoogleCloudPlatform/flink-on-k8s-operator/pull/436