SwayOSD icon indicating copy to clipboard operation
SwayOSD copied to clipboard

Use icon names from gnome-shell-extension-lockkeys

Open mochaaP opened this issue 2 years ago • 4 comments

Support system icon theme settings. Also, allow discrimination between enabled/disabled state

  • [ ] ask upstream (1, 2) for scroll lock support / drop scroll lock support on our side
  • [ ] use icons glyphs from upstream (1)
  • [ ] switch to Adwaita's icon name for audio / microphone
  • [ ] ~add option to discard gresource from binary / loading from external location (required for distribution packaging)~
  • [x] fix error on cargo package

mochaaP avatar Aug 19 '23 09:08 mochaaP

bb83b26b fixes the cargo package issue.

add option to discard gresource from binary / loading from external location (required for distribution packaging)

Why would this be necessary?

ErikReider avatar Nov 22 '23 11:11 ErikReider

@ErikReider:

Why would this be necessary?

This mutates the source tree (usage of include_bytes) when invoking build.rs, which could cause some weird behavior while used alongside Fedora's Rust SRPM macros. (I forgot the exact details since it has been 3 months away from the original attempt, sorry 😅)

mochaaP avatar Nov 22 '23 16:11 mochaaP

@ErikReider:

Why would this be necessary?

This mutates the source tree (usage of include_bytes) when invoking build.rs, which could cause some weird behavior while used alongside Fedora's Rust SRPM macros. (I forgot the exact details since it has been 3 months away from the original attempt, sorry 😅)

What would be an alternative?

ErikReider avatar Dec 08 '23 13:12 ErikReider

20d23ea removes the need for decoupling the gresource from the application

ErikReider avatar Dec 10 '23 21:12 ErikReider