EntityFramework.SqlServerCompact icon indicating copy to clipboard operation
EntityFramework.SqlServerCompact copied to clipboard

Fixed the InterpretExistsResult condition

Open cincuranet opened this issue 6 years ago • 6 comments

The value is never going to be NULL, it's either 0 or (hopefully :)) 1.

cincuranet avatar Feb 20 '19 09:02 cincuranet

Hmm, the failing build doesn't look good. Now whether it found real issues or it's a bad change. I still think the new code is correct, isn't it?

cincuranet avatar Feb 20 '19 10:02 cincuranet

I am not sure it is correct if functional tests are failing

ErikEJ avatar Feb 20 '19 12:02 ErikEJ

I got the inspiration as I was writing my code and also SQLite provider does the same. The original condition makes sense in case of SQLServer, because the query is different.

cincuranet avatar Feb 20 '19 13:02 cincuranet

Should this be closed then?

ErikEJ avatar Feb 20 '19 14:02 ErikEJ

Hang on: try with: Convert.ToInt32 !! (COUNT() is int, not bigint)

ErikEJ avatar Feb 20 '19 16:02 ErikEJ

Doesn't matter. The Convert will handle it.

cincuranet avatar Feb 20 '19 16:02 cincuranet