codechecker icon indicating copy to clipboard operation
codechecker copied to clipboard

Published 20 hours ago • verified publisher icon Ericsson

Upgrade thrift compiler to 0.15.0

Open csordasmarton opened this issue 4 years ago • 7 comments

Pypi and npm packages are available for thrift 0.15.0 version so we can try to upgrade it:

  • https://www.npmjs.com/package/thrift/v/0.15.0
  • https://pypi.org/project/thrift/0.15.0/

Unforunately the docker image what we used during development is deprecated and doesn't have an image for this version. So we have to build our own image (codechecker/thrift) based on the following configuration file: https://github.com/ahawkins/docker-thrift/blob/d7e73876549d205898b1922bcbf69e74ef11c288/0.12/Dockerfile

csordasmarton avatar Oct 12 '21 08:10 csordasmarton

There is a bug in the 0.15.0 thrift (Python part) and for now we can't upgrade to this version until it is fixed. For more information see: https://issues.apache.org/jira/projects/THRIFT/issues/THRIFT-5467.

csordasmarton avatar Dec 14 '21 12:12 csordasmarton

I created a patch to solve this problem: https://github.com/apache/thrift/pull/2491

csordasmarton avatar Dec 16 '21 09:12 csordasmarton

Okay, now the patch is merged, but we have to wait the next release (>0.16.0).

csordasmarton avatar Feb 24 '22 07:02 csordasmarton

thrift is now on version 0.18.1.

I cant compile codechecker on soon-to-be-reelased debian "bookworm" anymore since the old thrift fails to compile.

nolange avatar Mar 22 '23 08:03 nolange

Ping? thrift 0.13.0 belongs into a museum!

nolange avatar Jul 03 '23 08:07 nolange

Hi,

I started to check this upgrade. But may I ask, what workflow does it prevent in Debian? I mean, we have a "make build" target in the "api" directory which uses a docker container to build the Thrift api in a container. What is the motivation of building stubs natively on the host machine?

There is also a second issue: the latest Thrift version is 0.16 on pypi. It seems like it is not maintained, so probably that should be the latest one that we could use.

bruntib avatar Jul 20 '23 15:07 bruntib

Hi,

I started to check this upgrade. But may I ask, what workflow does it prevent in Debian? I mean, we have a "make build" target in the "api" directory which uses a docker container to build the Thrift api in a container. What is the motivation of building stubs natively on the host machine?

I dont know, I did run pip install codechecker and it failed when installing / compiling thrift. It does work now - so I don't know what was the issue.

There is also a second issue: the latest Thrift version is 0.16 on pypi. It seems like it is not maintained, so probably that should be the latest one that we could use.

The last version of codechecker on pypi is 6.22.1, and not the current release. Does this mean its not maintained?

nolange avatar Jul 20 '23 20:07 nolange