orion icon indicating copy to clipboard operation
orion copied to clipboard

[WIP] HPO remote service

Open Delaunay opened this issue 3 years ago • 6 comments

Base implementation to get some ideas

Delaunay avatar May 26 '22 13:05 Delaunay

What do you think of FastAPI? https://fastapi.tiangolo.com/#example

I don't know these tools personally, but this looks intersting to me

lebrice avatar May 26 '22 15:05 lebrice

It does look good, I used falcon because that is what is currently used in the repo. The falcon way looks a bit verbose indeed

Delaunay avatar May 26 '22 15:05 Delaunay

I don't know them very well either. We would need to make sure it is worth converting current code to FastAPI if we want to adopt it. Now would be the best time to take a look before the webapi becomes too large to be worth converting.

bouthilx avatar May 26 '22 17:05 bouthilx

I don't believe the library will impact us in a significant way. It is akin to selecting a logging library, their purpose is very well defined and it will not drive the design of what we are trying to achieve. This is just going to be about selecting the one what has the most sugar.

It is better you guys select the one you will want to work with because i don't mind. Feature wise they all look the same.

Delaunay avatar May 27 '22 17:05 Delaunay

As of now I don't know them enough to make a decision. Unless someone has time to investigate I'd just go with status quo and continue with falcon.

bouthilx avatar May 27 '22 17:05 bouthilx

It could be worth taking the time to investigate it and actually try it out before ruling it out, since if it indeed does makes the code very clean and simple to read, this would have great benefits on the long run, as we grow the API.

lebrice avatar Jun 01 '22 13:06 lebrice