Enzyme.jl icon indicating copy to clipboard operation
Enzyme.jl copied to clipboard

Add Turing integration tests

Open mhauru opened this issue 1 year ago • 3 comments
trafficstars

Makes log density functions out of a bunch of Turing.jl models and checks that Enzyme can differentiate them, both in Forward and Reverse modes.

Related issues that should probably be sorted before merging this:

  • #1812
  • #1811
  • #1807

mhauru avatar Sep 12 '24 11:09 mhauru

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.92%. Comparing base (037dfed) to head (6154f90). Report is 61 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1813      +/-   ##
==========================================
+ Coverage   67.50%   69.92%   +2.41%     
==========================================
  Files          31       32       +1     
  Lines       12668    13645     +977     
==========================================
+ Hits         8552     9541     +989     
+ Misses       4116     4104      -12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 12 '24 11:09 codecov-commenter

Can turing and all dependencies be pinned to exact versions

On Thu, Sep 12, 2024, 6:57 AM Codecov Comments Bot @.***> wrote:

⚠️ Please install the Install_Codecov_app_button.svg (view on web) https://github.com/codecov/engineering-team/assets/152432831/e90313f4-9d3a-4b63-8b54-cfe14e7ec20d to ensure uploads and comments are reliably processed by Codecov. Codecov https://app.codecov.io/gh/EnzymeAD/Enzyme.jl/pull/1813?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.92%. Comparing base (037dfed) https://app.codecov.io/gh/EnzymeAD/Enzyme.jl/commit/037dfed7a2a5af4b577546ff7c879a3adbbe7058?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None to head (6154f90) https://app.codecov.io/gh/EnzymeAD/Enzyme.jl/commit/6154f906e5714ce5b4d9e4f16bfc0b787f660aa4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None . Report is 61 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app https://github.com/apps/codecov/installations/select_target to enable full functionality. Additional details and impacted files

@@ Coverage Diff @@## main #1813 +/- ## ==========================================+ Coverage 67.50% 69.92% +2.41%

Files 31 32 +1 Lines 12668 13645 +977 ==========================================+ Hits 8552 9541 +989 + Misses 4116 4104 -12

☔ View full report in Codecov by Sentry https://app.codecov.io/gh/EnzymeAD/Enzyme.jl/pull/1813?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None . 📢 Have feedback on the report? Share it here https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None .

— Reply to this email directly, view it on GitHub https://github.com/EnzymeAD/Enzyme.jl/pull/1813#issuecomment-2346089955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJTUXDTSYLITHH2EM54EV3ZWF6UFAVCNFSM6AAAAABODASDEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWGA4DSOJVGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

wsmoses avatar Sep 12 '24 13:09 wsmoses

I changed the dependency from Turing to DynamicPPL and Distributions since we don't do any sampling. I pinnned those two and their major depencencies: AbstractMCMC, AbstractPPL, Bijectors, LogDensityProblems, LogDensityProblemsAD. Can pin all the dependencies if you'd like (BangBang, OrderedCollections, etc.), but I wonder if in that case it would make more sense to just commit the Manifest.toml.

mhauru avatar Sep 12 '24 14:09 mhauru

@penelopeysm can you help get this integrated with the modern CI workflow for integration tests?

wsmoses avatar Sep 30 '25 04:09 wsmoses