yoroi-frontend
yoroi-frontend copied to clipboard
Use Chrome manifest V3
See the comment of https://emurgo.atlassian.net/wiki/spaces/YE/pages/739311617/Checklist+to+upgrade+to+manifest+v3 for documentation.
The extension size is unreasonably big. it is 107 MB!! The current extension size is < 1 MB (dev). The final nightly size is about 30 MB.
in the dev/js directory, there are a lot of assets/wasm files. Is there any reason for this?!
Details
@yushih For some reason, my terminal doesn't work when I try to exit the server while using stumx. I am using bash on MaxOS. I don't know if I have a problem with my terminal but we can use Concurrently for the same use case.
The extension size is unreasonably big. it is 107 MB!! The current extension size is < 1 MB (dev). The final nightly size is about 30 MB. in the
dev/jsdirectory, there are a lot of assets/wasm files. Is there any reason for this?!
@AhmedIbrahim336 , when I try building the extension zip file, I'm getting 26.6 megabytes, which is roughly the same as in production at the moment.
@AhmedIbrahim336 , when I try building the extension zip file, I'm getting 26.6 megabytes, which is roughly the same as in production at the moment.
@vsubhuman What about when you unzip it? The current size of the unzipped nightly build is about 50MB
@AhmedIbrahim336 the bloating of /dev dir size is expected. Because originally, the dir only had to hold background.html, and all chunks of the background script were served by webpack-dev-server from memory. But now that mv3 allows only a JS background service worker module, it has to be written to disk (writeToDisk: true in webpack/devConfig.js).
I'll take a look into the production bundle size.
@AhmedIbrahim336 the bloating of /dev dir size is expected. Because originally, the dir only had to hold background.html, and all chunks of the background script were served by webpack-dev-server from memory. But now that mv3 allows only a JS background service worker module, it has to be written to disk (writeToDisk: true in webpack/devConfig.js).
@yushih Got it. If we can bundle all these assets into a separate directory this will be much cleaner.
[autoscript] ⚠️ yushi/manifest-v3 doesn't full our branch naming convention.
Should follow <tag>/<jira-ticket-id>/<short-name>
Details
<tag>:fix,feat,chore,refactor,test, ...<jira-ticket-id>: The issue ID of JIRA all capital letters<short-name>: A short and descriptive name for the branch
SonarQube Quality Gate
Reliability Rating on New Code (is worse than A)
Security Rating on New Code (is worse than A)
0.0% Security Hotspots Reviewed on New Code (is less than 100%)
See analysis details on SonarQube
Fix issues before they fail your Quality Gate with
SonarLint in your IDE.
