cardano-serialization-lib icon indicating copy to clipboard operation
cardano-serialization-lib copied to clipboard

`RewardAddress`, `BaseAddress`, `EnterpriseAddress`, `PointerAddress` have no getter for network id

Open klntsky opened this issue 1 year ago • 3 comments

Address type does have it, but it is not convenient to convert every time a network id is needed.

klntsky avatar Jan 22 '24 16:01 klntsky

Hi @klntsky! Hm we can add it in the next version : )

lisicky avatar Jan 25 '24 07:01 lisicky

wasn't the PointerAddresssupposed to 'die', because noone ever used it? should it than being removed from the lib?

gitmachtl avatar Jan 25 '24 08:01 gitmachtl

@gitmachtl if it will be removed from the next CDDL we can deprecate PointerAddress in the CSL API. But as I see it still exists in the conway CDDL https://github.com/IntersectMBO/cardano-ledger/blob/5f76eb918c16645ed98a7fbab513c2d549837ed5/eras/conway/impl/cddl-files/conway.cddl#L264-L265

lisicky avatar Jan 25 '24 08:01 lisicky

the lates CSL 12 should have it

lisicky avatar Aug 12 '24 17:08 lisicky