IntelliJ-EmmyLua
IntelliJ-EmmyLua copied to clipboard
EmmyLua
2024.3 release compatibility
I guess this fixes #593
Also @hurricup are all of these changes required for compatibility with 2024.3?
Yes. Gradle plugin needs to build plugins with modern versions of ides (sometimes old one works, but this is temporary) And it requires the recent gradle version. Most of the changes are: gradle dsl migration and gradle files auto-update. And yes, it is ready to go for 2024.3
@tangzx could you please merge my changes. you are pushing additional stuff to the configuration fiels making it hard to merge. Rebased on the current master
The main issue is that the debugging-related API has been marked as internal, so the entire plugin was rejected for review.
Do you need an assistance with the migration?
Yesterday's commit should have fixed this issue, so it might currently be under review. Also, isn't emmylua2 available for use?
I came here while trying to fix the plugin for the factorio mods development. And it relies on emmylua. Not sure if they are interchangeable.
I came here while trying to fix the plugin for the factorio mods development. And it relies on emmylua. Not sure if they are interchangeable.
you can give it a try.
Why don't you merge this as well? It upgrades gradle plugin and gradle. You are going to need this.
Why don't you merge this as well? It upgrades gradle plugin and gradle. You are going to need this.
EmmyLua actually hasn't had any functional updates. PRs are mostly not merged. I just occasionally check issues. If you want, I can keep this PR open, but tangzx is unlikely to merge it.
So I have my own maintained version of EmmyLua called EmmyLua2. If you are willing to submit PRs for it, I will merge them promptly.
I see. Then it is worth looking into emmylua2 then :) Is it a fork of this plugin? And what is the story behind this plugin? I mean - why is it not updated anymore?
I see. Then it is worth looking into emmylua2 then :) Is it a fork of this plugin? And what is the story behind this plugin? I mean - why is it not updated anymore?
The EmmyLua2 plugin merely inherits removes most of the functionality from EmmyLua, and use EmmyLuaAnalyzer as backend. This way, I only need to maintain one codebase.
As for the story, you should know that we are maintaining the plugin in our spare time, and the author has gone to take care of their child.
I see. Sad that even PRs not accepted. I was thinking on contributing here a bit.
Is it going to be ok with everyone if I fork this (non lsp) plugin and work on it a bit, publishing as a separate plugin? There are some plugins depending on this one and they may not be able to migrate to lsp based solution.
Or may be I could be made a contributor here with ability to fix/release things.
I was thinking about this as well, but this may be inconvenient for the current users. To have multiple similar (almost same) plugins. Is there a reason you are not accepting contributors?
I was thinking about this as well, but this may be inconvenient for the current users. To have multiple similar (almost same) plugins. Is there a reason you are not accepting contributors?
This is not my repository, so I cannot make decisions for it. If it really needs to be updated, I will update it myself.
Yes, I understand it, but seems you are in contact with an owner and he is not communicating here and he could make a decision. Well, issue tracker says there are things that could be done here.