erpc icon indicating copy to clipboard operation
erpc copied to clipboard

Feature Request: Transport without crc

Open aelray opened this issue 4 years ago • 6 comments

Hi, I'm using ERPC with CDC ACM (Connection between x64 and microcontroller) and I would love to disable CRC checking because I think USB does that already for me and I think it's a waste of ressources to put an additional CRC check on top. Cheers!

aelray avatar Jun 18 '21 19:06 aelray

Hi eRPC user. Thank you for your interest and welcome. We hope you will enjoy this framework well.

github-actions[bot] avatar Jun 18 '21 19:06 github-actions[bot]

Hi @aelray , there is no simple way how to do it using any settings or configuration. You could try to modify the erpc_framed_transport.cpp/.h code directly, disabling m_crc calculation in the send method and also the crc checking in the receive method. This is quite easy adjustment, I think. Hope it helps. Regards Michal

MichalPrincNXP avatar Jun 25 '21 11:06 MichalPrincNXP

shouldn't anyone provide a configuration class for erpc, so that these things can be configured properly at runtime/buildtime instead of suggesting that people just fork their own erpc version to just change a minor thing?

kikass13 avatar Jun 26 '21 09:06 kikass13

@aelray , attached is the updated code with the new ERPC_CRC config macro (needs to be set in your erpc_config.h file) to try on your side. Note, this has not been fully tested. Please let me know if this is sufficient for you? Thank you Michal erpc_c.zip

MichalPrincNXP avatar Jun 28 '21 10:06 MichalPrincNXP

@aelray , attached is the updated code with the new ERPC_CRC config macro (needs to be set in your erpc_config.h file) to try on your side. Note, this has not been fully tested. Please let me know if this is sufficient for you? Thank you Michal erpc_c.zip

Thank you! I will try when I have time

aelray avatar Jul 01 '21 07:07 aelray

Hello, i will do version without CRC. I would like to do it without macro, maybe just with inheritance.

Hadatko avatar Aug 28 '23 06:08 Hadatko