rust-gpu
rust-gpu copied to clipboard
We should consider using `#[rustc_on_unimplemented]` on `spirv-std` helper traits.
I was reviewing this nightly bump PR:
- https://github.com/EmbarkStudios/rust-gpu/pull/982
And its diff shows some nightly diagnostic improvements of the form:
12 | *output = image.query_levels();
- | ^^^^^ ------------ required by a bound introduced by this call
- | |
- | the trait `HasQueryLevels` is not implemented for `Image<f32, 4, 2, 0, 0, 1, 0>`
+ | ^^^^^^^^^^^^ the trait `HasQueryLevels` is not implemented for `Image<f32, 4, 2, 0, 0, 1, 0>`
|
= help: the following other types implement trait `HasQueryLevels`:
Image<SampledType, 0, DEPTH, ARRAYED, MULTISAMPLED, SAMPLED, FORMAT>
That's definitely better, but the trait can't really explain itself and its connection to the types (i.e. "Image types support query_levels only if such and such parameters have these values" etc.).
Except, in core/std, traits can and very much do do this, using #[rustc_on_unimplemented]!
It's perma-unstable, and there might be efforts to stabilize a subset of it, but even ignoring that, we can still use it under #[cfg_attr(target_arch = "spirv", ...)], just like all the other rustc internals we rely on.