rust-gpu
rust-gpu copied to clipboard
EmbarkStudios
Remove unused attributes from storage class
Sorry for the late reply, I'm just now catching up after the holiday. I ran the test suite before I submitted the pull request, but I've only just realized the CI test stage is running tests differently. I'm new to the project so I'm not sure what needs to be changed. If you could clarify or provide some context for the necessary changes, I would definitely appreciate it. I'm still happy to work on this task.
Sorry for the late reply, I'm just now catching up after the holiday. I ran the test suite before I submitted the pull request, but I've only just realized the CI test stage is running tests differently. I'm new to the project so I'm not sure what needs to be changed. If you could clarify or provide some context for the necessary changes, I would definitely appreciate it. I'm still happy to work on this task.
As you removed all the attributes that are used in the test: https://github.com/EmbarkStudios/rust-gpu/blob/main/tests/ui/spirv-attr/invalid-storage-class.rs, the failure message of the test is now different.
You could either run the test command cargo run -p compiletests --release --no-default-features --features "use-installed-tools" -- --target-env vulkan1.1,vulkan1.2,spv1.3 with the --bless flag, or probably just remove the test as it doesn't make sense anymore.
I removed the test case that you mentioned. I did run the command with the --bless' to retest but it looks like it changed several files. Let me know if this should be reverted and just delete the test case.
Additionally, the errors themselves needs to be updated, as they can no longer happen.
