composer-push icon indicating copy to clipboard operation
composer-push copied to clipboard

[Enhancement] Make the <version> cli parameter optional

Open TurinTuramba opened this issue 6 years ago • 3 comments

Hello,

please make the cli parameter optional, because the version information are already in the composer.json file. At the moment it is possible for example to push the version 1.0.0 with the cli-version 2.0.0 this is ambiguous and irritating.

Thx Roland

TurinTuramba avatar Jun 06 '19 08:06 TurinTuramba

Hi @TurinTuramba, it's a good idea and I'll take a look as soon as I have some time to address this issue and make the version optional if such parameter is provided in the composer.json file.

Elendev avatar Jun 06 '19 08:06 Elendev

Hi, just chipping in on this issue. We forked this repository and maintain our own internal branch which is particularly aimed at running this in GitLab CI. We made this parameter sort-of optional. It's required when the CI_COMMIT_TAG environment variable is not present (E.G. when not running on a release tag).

ghost avatar Nov 12 '19 06:11 ghost

This was resolved in #56

tm1000 avatar Dec 28 '22 17:12 tm1000