simplicity icon indicating copy to clipboard operation
simplicity copied to clipboard

Renamed jets

Open uncomputable opened this issue 1 year ago • 4 comments

The tech report and wiki include the following jets (in front of arrow), but the code base renamed them (after arrow).

  • tap-leaf-hash → tapleaf-hash
  • tapbranch → tappath
  • tapbranch-hash → tappath-hash
  • input-asset-amounts-hash → input-amounts-hash
    • issuance-asset-amounts-hash was not renamed
  • output-asset-amounts-hash -> output-amounts-hash

There may be more inconsistencies related to tap paths and asset amounts.

uncomputable avatar Jan 03 '24 13:01 uncomputable

The Tech Report seems fine to me.

roconnor-blockstream avatar Jan 09 '24 22:01 roconnor-blockstream

I was using a tech report from one year ago; oops.

Most of the jet names have been fixed. However, it's still tap-leaf-hash in the tech report and tapleaf_hash in the code.

issuance-asset-amounts-hash probably includes asset to differentiate it from issuance-token-amounts-hash. In that case, the longer name makes sense.

uncomputable avatar Jan 14 '24 09:01 uncomputable

Additionally bip0340-schnorr-verify is written in the tech report; however the code uses bip_0340_verify

roconnor-blockstream avatar Feb 06 '24 23:02 roconnor-blockstream

And check-sig-verify is missing from the tech report.

roconnor-blockstream avatar Feb 07 '24 22:02 roconnor-blockstream