libelektra icon indicating copy to clipboard operation
libelektra copied to clipboard

[CM T3] kdb: Fixed a bug where the mv-command deletes subkeys of the moved key.

Open Gratla opened this issue 3 years ago • 4 comments

Fixes #3648

Basics

  • [x] Short descriptions of your changes are in the release notes (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_) Please always add something to the release notes.
  • [x] Details of what you changed are in commit messages (first line should have module: short statement syntax)
  • [ ] References to issues, e.g. close #X, are in the commit messages.
  • [ ] The buildservers are happy. If not, fix in this order:
    • [ ] add a line in doc/news/_preparation_next_release.md
    • [ ] reformat the code with scripts/dev/reformat-all
    • [ ] make all unit tests pass
    • [ ] fix all memleaks
  • [ ] The PR is rebased with current master.

Checklist

  • [ ] I added unit tests for my code
  • [ ] I fully described what my PR does in the documentation (not in the PR description)
  • [ ] I fixed all affected documentation
  • [ ] I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • [ ] I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • [ ] I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • [ ] Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • [ ] Add the "ready to merge" label if the basics are fulfilled and no further pushes are planned by you.

Gratla avatar May 24 '22 18:05 Gratla

This PR wasn't marked as "CM", so I missed it. Otherwise I would have told you this sooner...

Please rebase and adapt your code. The next() function was recently removed. You can replace the while loop with a simple for loop.

kodebach avatar Jun 16 '22 12:06 kodebach

Also please add a test case somewhere that shows the new code works as intended.

kodebach avatar Jun 16 '22 12:06 kodebach

What is the alternative for the next() method? Right now there are no tests for this feature as fare as i know. Unfortunatly, I am very busy right now and only have limited time to fix issues here.

Gratla avatar Jun 17 '22 15:06 Gratla

Right now there are no tests for this feature as fare as i know.

The easiest place to add some would probably be testscr_check_basic, i.e. in tests/shell/check_basic.

kodebach avatar Jun 17 '22 15:06 kodebach

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new PR with the remainder of this PR. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar Jun 18 '23 02:06 github-actions[bot]

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new PR with the remainder of this PR. Thank you for your contributions :sparkling_heart:

github-actions[bot] avatar Jul 02 '23 02:07 github-actions[bot]