Uninstall: target fails without failed CI runs

[mpranj]

I noticed on cirrus (🍎 FULL), that the uninstall tests are failing without the build to fail/turn red.

See build log here, "Run tests" section.

I don't know since when this is happening.

[markus2330]

Thank you so much for reporting this! It is important that we have a look if our tests are actually testing what we think they do.

[stale[bot]]

I mark this issue stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping the issue by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

[kodebach]

@mpranj Is this still happening?

[mpranj]

Yes, it is.

[kodebach]

Based on the way the uninstall command is written in .cirrus.yml, it will never fail.

https://github.com/ElektraInitiative/libelektra/blob/5ebc9a4ba5215950f990f7dca948ce310f764079/.cirrus.yml#L202

The command basically says: Run the cmake command and only if it fails, print the output. But that also means this build step only fails, if printf fails.

What we want is probably something like:

output="$(cmake --build "$BUILD_DIR" --target uninstall 2>&1)"; ret=$?; if [ $ret != 0 ]; then printf '%s' "$output"; exit $ret; fi

But I'd just go with the much simpler:

cmake --build "$BUILD_DIR" --target uninstall 2>&1

Because it doesn't really matter, if the CI jobs produces some unless output

[github-actions[bot]]

I mark this stale as it did not have any activity for one year. I'll close it in two weeks if no further activity occurs. If you want it to be alive again, ping by writing a message here or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart:

[github-actions[bot]]

I closed this now because it has been inactive for more than one year. If I closed it by mistake, please do not hesitate to reopen it or create a new issue with the remainder of this issue. Thank you for your contributions :sparkling_heart: