electron-app-store icon indicating copy to clipboard operation
electron-app-store copied to clipboard

[BUG] App Screenshots do not appear

Open cjerrington opened this issue 3 years ago • 3 comments

I really like this idea as I've used the electronjs.com/apps and have found a lot of exciting projects! It has the linux or app store kind of feel to the electron community. However, there are no images in the 0.0.4 release on Windows. The app icons are broken.

To Reproduce Windows 10 0.0.4 Release

Expected behavior Show screenshots and app icons where appropriate

Screenshots electron-store

Desktop (please complete the following information):

  • OS: Windows 10
  • Build .exe
  • Version 0.0.4

Additional context This might be due to the way you are reading the apps .yml data? I've noticed even on the electronjs.org/apps site, the screenshots do not appear there either.

cjerrington avatar Apr 19 '22 03:04 cjerrington

Unfortunately, the v0.0.4 and older versions of the App Store use the older API which just parses the https://electronjs.org/apps website and the reason the screenshots and icons are not appearing is CORS Issue. I've created a new API that fixes the CORS Issue and many more issues but also introduces some major API changes. Therefore, the existing version of the App Store isn't compatible with it. So, I'm currently working on the full rewrite of the App Store. Currently, I'm the only contributor of this App Store so it's taking some more time.

rustdevbtw avatar Apr 19 '22 08:04 rustdevbtw

Awesome! I saw that a 0.0.5 was mentioned in another issue so this looks to be resolved in upcoming releases? Should we keep this open until that release if others are experiencing the same thing?

Sounds like you have a plan for the rewrite. I can try to help once that is completed!

cjerrington avatar Apr 19 '22 15:04 cjerrington

You're right, we should keep this issue open until v0.0.5 is released. Also, most API-related issues are fixed with the new API which is incompatible with the current Electron App Store because it introduces some breaking changes. So, I'm currently working on the full rewrite of the App Store with React (+ Chakra UI) and TypeScript. The newer version will also have new design changes and a complete design revamp as well as many new and revamped features. But as I'm currently the only active maintainer of this project, it's taking more time than usual.

rustdevbtw avatar Apr 20 '22 09:04 rustdevbtw