electron-app-store icon indicating copy to clipboard operation
electron-app-store copied to clipboard
verified publisher icon Electron-Store

Fix 2 Maintainability issues in main\downloadManager.js

Open rustdevbtw opened this issue 3 years ago • 2 comments

CodeFactor found multiple issues:

'fileURL' is defined but never used.

'downloadFile' is defined but never used.

And why https://ovh.net/files/1Gio.dat (1GB in size) is downloaded?

@Patrick-Web

rustdevbtw avatar Dec 22 '21 15:12 rustdevbtw

'defined but never used', that means they can just be deleted right?

jdev082 avatar May 31 '22 17:05 jdev082

@JaydenDev It's weird but true. Actually, the codebase is messy and needs a cleanup. Additionally, the new re-written version of Electron App Store would take some time to complete (as I'm working on it alone).

rustdevbtw avatar Jun 02 '22 08:06 rustdevbtw