Ashcon Partovi

Results 383 comments of Ashcon Partovi
trafficstars

> @Electroid @paperdave Regarding `__filename` and `__dirname`. Do we really need to redefine them **and** mark them as deprecated? Typescript already handles the types for them depending if you are...

> > In Bun, those work in both mjs and cjs, so it may make sense to keep the overrides. > > I am aware, but, usually you want people...

@Didas-git Looks like CI for types is failing due to TS issues, mind taking a look?

We'll have to fix our CI later, thanks for working on this. Big improvement.

This would for sure be a breaking change, that said, I’m curious what @zackradisic thinks.

We do plan to make this change before Bun v1.1. We will communicate this as a breaking change

Going to re-open until we make this the default behaviour.

Can you share the exact command you are running?

Looks good, could we add a test somewhere in `test/js/node` so this doesn't regress?

Oops, I didn't intend to commit that. I think the test is slightly over-engineered. If you remove it from the commit, I'll just merge this small fix.